Apply tags to Elastic Search domain resources after creation. #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Elastic Search Domain resource takes about 10 minutes to create. During this time, many things may go wrong to break the behaviour of the Terraform system - network drops, token expiry, system crashes, accidentally closing the wrong terminal, etc... In such cases, the resource will have been created but not be tagged. So, as well as Terraform losing track of it, the tracking tags would not give an indication of why it existed in the first place. The current code creates the domain and then waits until it has completed construction before setting the tags. It also seems to use the partial completion interface, which seems redundant as it immediately completes the operation. In any case, moving the tag setting operations before the wait means that the tags are present as early as possible, allowing the resource to be identified. And that tiny amount of time is absorbed into the long domain creation, making things marginally faster.
radeksimko
added
the
enhancement
radeksimko
approved these changes
Aug 23, 2017
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
…csearch-domain-before-waiting Apply tags to Elastic Search domain resources after creation.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Elastic Search Domain resource takes about 10 minutes to create.
During this time, many things may go wrong to break the behaviour of
the Terraform system - network drops, token expiry, system crashes,
accidentally closing the wrong terminal, etc... In such cases, the
resource will have been created but not be tagged. So, as well as
Terraform losing track of it, the tracking tags would not give an
indication of why it existed in the first place.
The current code creates the domain and then waits until it has
completed construction before setting the tags. It also seems to
use the partial completion interface, which seems redundant as
it immediately completes the operation.
In any case, moving the tag setting operations before the wait
means that the tags are present as early as possible, allowing
the resource to be identified. And that tiny amount of time is
absorbed into the long domain creation, making things marginally
faster.